Use Treq for Twisted integration #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 25, 2016
Closed
|
Thanks @zgoda-mobica ! We will review this in the coming week. |
| r = requests.Response() | ||
| r.status_code = resp.code | ||
| r.headers.update(resp.headers.getAllRawHeaders()) | ||
| return treq.content(response).addCallback(post_data_cb, r) |
There was a problem hiding this comment.
This is breaking for me here. Did you mean to write return treq.content(resp).addCallback(post_data_cb, r)? I think that should do what you intended.
|
Merged in #109 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treq is requests-like library for Twisted made by Twisted developers. This branch contains complete rewrite of Twisted support code that uses Treq for web requests.